Repository navigation
Fix PR11 context freshness coverage and ADR status acceptance - #12
Merged
overlordxrz-source merged 8 commits intoOct 25, 2026
Merged
overlordxrz-source merged 8 commits into
overlordxrz-source merged 8 commits into
Conversation
overlordxrz-source
marked this pull request as ready for review
October 25, 2026 00:53
overlordxrz-source
merged commit Oct 25, 2026
ad02f31
into
docs/persistent-context-protocol
1 check passed
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest remediation — independent re-review requested
Current exact head:
207aa92ba79273664f12bd68ce36a6ee86a42d4e.OpenCode's remaining P2 finding at
e30c1e58e93a27f55a99fa3857aac354693a5463is corrected on this existing branch. The legacy alias is now keyed by (ADR identity, normalized status); only(ADR-004, accepted research policy)maps to accepted. ADR-007, synthetic ADR-010 and every other identity reject that spelling.a662a8d: committed the regressions before the fix; 4 failed, 31 passed, independently reproducing parser and generator/checker acceptance for the wrong identities.5b4b120ad0f14c5afa788bdaccf00d15b65863fa: identity-scoped parser, exact governing grammar, regression/probe cases and protected process hash. Also rejects a blank status line consuming the next line, caught by a further failing grammar control.4dd2c3d4299f88ba4f2b19b1c557d09c421dde01: derived Brief regenerated from committed sources.207aa92ba79273664f12bd68ce36a6ee86a42d4e: durable remediation evidence and branch-safe handoff.Verification observed locally on the corrected head:
context_brief.parse_adrs.Hosted CI: SUCCESS at this exact head: run 40147822894. The offline suite and persistent-context integrity steps completed successfully.
Exact allowable grammar and the sole exception are in DECISION_CHANGE. Metadata after the first middle dot is informational; CI still cannot authenticate owner consent.
Remediation report and commands · Saved failing controls / before-after evidence.
For independent re-review, check out this exact correction head in a separate clone and run:
Inspect individual result codes, not just the driver's exit. All mutations happen in disposable clones. No accepted ADR, architectural intent, sensor application, firmware, hardware, CI settings or frozen Alpha evidence changed. No Context Autopilot was started; no PR was merged. The historical 322-test PR10 rehearsal below is separate, not incorporated or rerun for this fix.
OpenCode: please independently re-review exact head
207aa92ba79273664f12bd68ce36a6ee86a42d4e, including identity scoping and the grammar's negative controls. Existing REQUEST CHANGES remains until independent verification.Historical original publication — earlier head and test counts, superseded by the update above
This corrects two governance-integrity defects independently reproduced in PR #11 at
b58c96ef998e68e841b12d9ad671325053c009e4: omitted protected sources could change without invalidating the Brief, and ADR status prefixes could promote pending approval to active accepted. This draft targets docs/persistent-context-protocol, not main. Independent re-review requested; do not merge either PR as part of verification.Exact correction head:
e30c1e58e93a27f55a99fa3857aac354693a5463.Original PR #11 history is preserved. This head adds four commits without rewriting it:
3f9c647: regressions first (7 failed, 1 passed before fixes).2a5b7489330d4c0dd4c57717d5192c1a02e2a382: enforce all 18 protected sources; exact ADR statuses, explicit legacy alias, and preserve full decision maturity wording.bd3433c8410dd0d3ac51de6f1a64760a00fd4521: regenerate the derived Brief from the corrected source configuration.e30c1e58e93a27f55a99fa3857aac354693a5463: report, machine-readable evidence, branch-safe handoff and reproducible disposable-clone probes.No owner-approved architecture, protected canonical document, firmware, sensor application, frozen Alpha evidence or CI configuration changed. The old Brief source commit
71a54ede…was valid at the original final head: all declared/protected source bytes still matched. The freshness defect concerns later changes to the six omitted governance sources.Exact before/after reproduction
Use a separate clone; do not check out or reset OpenCode's active worktree. Fetch full history, check out this correction branch, create a local environment and install the CI dependencies. Commands below use python3; adapt the interpreter to the existing project environment if preferred.
Both mutation suites operate in disposable clones; the source checkout is not mutated. Their process exit is not the aggregate assertion: inspect each case's
exit_codein results.json.governance_refreshed_without_brief: append to DECISION_CHANGE, update protected manifest, synthetic commit, leave Brief untouchedinvalid_status_prefix: set ADR-007 to accepted_pending_owner_approval, refresh manifest, synthetic commit, attempt Brief generationunauthorized_all_refreshed: no owner approval, content + hashes + Brief all refreshedThe eight regression cases also cover invalid accepted/proposed/superseded suffixes, a valid proposed ADR staying inactive, missing protected-source coverage and preserving owner-directed/draft-implementation maturity. No accepted architecture intent was changed.
Fresh verification at the published SHA
8a84369941c74d5f884c9ec6cc33d10395223597: 322 passed, 1 deselected, context/architecture PASS, all 24 noncombined PR10 changed paths byte-preserved.PR #10 integration is separate and unmerged
This correction PR contains no PR10 application changes. The 322 count belongs only to a temporary combined tree, not to this PR's own suite. Main/base for the rehearsal is
f2ef96b0cfe48e2e47c9d4ac02b3ac8e3376a2a2.To reproduce separately from the same checkout/environment:
If PR10 has moved, obtain its exact approved SHA above before running; the script deliberately uses fixed reviewed heads.
Exact reconciliation strategy for the one content conflict,
docs/handbook/agent-handoff.md:docs/context/handoffs/approved-pr10-bench-evidence.md, with a canonical pointer; do not choose either entire handoff as a wholesale replacement.../to../../. Initial rehearsal caught six broken links before this correction; retain that failure in the audit record.The script only creates virtual Git tree objects and a disposable clone. It does not merge or move either PR branch.
Owner approval: explicit limit and proposed enforceable controls
CI checks hashes and grammar; it cannot independently authenticate owner approval. Refreshing every manifest and the Brief can still pass without consent, exactly as AUTOMATION_LIMITS and DECISION_CHANGE document. A receipt, accepted-status string, passing test or automated reviewer is not owner architectural approval.
Proposals only — not configured by this PR and not asserted to be enabled:
These options are supported by GitHub's protected-branch documentation and ruleset documentation. No repository settings were changed here.
Durable review artifacts / request
The checked-in report's “local / no remote changes” statements describe the completed original audit; this PR publishes that exact immutable checkpoint under the owner's subsequent authorization. Fresh results above repeat the controls at the published SHA.
OpenCode: independently re-review this exact head and both before/after mutation cases. PR11's original head remains REQUEST CHANGES until corrections are adopted and its resulting head is reviewed. Do not merge this correction PR, PR11 or PR10, change architecture intent, open devices or touch frozen experiments as part of verification.