Repository navigation
chore(gitignore): restore firmware build and lab-credential ignores on main - #14
Merged
Merged
Conversation
…n main The ignore block for the SoftAP CSI firmware build outputs and the lab WPA2 credential (lab.env, generated lab_credentials.h) was added in a5d25d3 on feature/alpha002-esp32-supervisor but never reached main. A checkout of main with a local firmware build therefore shows the credential and every build artefact as untracked, one `git add -A` away from a public commit. Secret-scanning push protection does not cover a generic Wi-Fi passphrase. Ported verbatim from a5d25d3. No tracked file changes; the firmware source paths remain trackable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ignore rules for the SoftAP CSI firmware build outputs and the lab WPA2 credential were added in
a5d25d3onfeature/alpha002-esp32-supervisor, but they never reachedmain.A checkout of
mainthat contains a local firmware build therefore lists these files as untracked:firmware/esp32-csi/softap_csi/lab.envlab_credentials.h.bin,.elf,.map)A single
git add -Awould then commit the lab passphrase to this public repository. Secret-scanning push protection is on, but it does not recognise a generic Wi-Fi passphrase.I checked every commit on every ref, and the passphrase has never been committed. This PR is preventive.
Change
.gitignoreonly. The block is copied unchanged froma5d25d3. It ignores:softap_csi/build/,build-softap/andbuild-station/managed_components/sdkconfig*files anddependencies.locklab.envandmain/lab_credentials.hVerification
git check-ignore --no-indexagainst the untracked files in a localmaincheckout that has a firmware build. All 3,996 files are now ignored, including both credential files and both build directories.main/app_main.c,CMakeLists.txtandsdkconfig.defaults.pytest -m "not hardware"reports 350 passed.tools/check_architecture.pyandtools/check_context.pyboth report PASS.Scope and notes
5073741. No tracked files change.main. It lives only onfeature/alpha002-esp32-supervisor. Bringing it here is a separate decision.dependencies.lockis ignored, as ina5d25d3. ESP-IDF generally recommends committing that file for reproducible component versions, so consider tracking it once the firmware source lands onmain.🤖 Generated with Claude Code