Parse media types with mime#1383
Draft
danieleades wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mimeas a direct dependency ofprogenitor-implmime::Mimeand classify them by their parameter-free essenceWhy
Media types were previously handled with two separate string-based approaches: request bodies sliced at the first semicolon, while responses used equality and prefix checks. Using a media type parser centralizes the syntax handling and makes the supported content-type policy explicit.
Impact
Existing supported body types retain their generated behavior. Valid media type parameters and case variations are handled consistently, while
application/problem+jsonremains unsupported rather than implicitly changing the generator's structured-suffix policy.Validation
cargo fmt --all -- --checkcargo test -p progenitor-impl(17 unit tests, 9 output tests, and 3 non-network specific tests passed in the sandbox)cargo test -p progenitor-impl --test test_specific(4/4 passed with localhost binding enabled)