Repository navigation
test: add packaged host entry smoke check in workerd - #2
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Intent
quero agora que olhe esse relatorio de revisão e spawne bots pra resolver tudo, tanto na baileyrs quanto no nosso exemplo https://github.com/jlucaso1/agent-workbox/issues/4
This lane owns the public example’s consumer-side proof. The report identifies a missing packaged /host workerd/Wrangler smoke with nodejs_compat off, a missing installed-tarball upstream-alias/deep-import check in baileyrs, and a gap between static host boundaries and actual Cloudflare runtime behavior. Inspect the already merged #1 to see whether it really exercises a packaged baileyrs preview in Workers and restart/auth behavior; close only gaps that belong in this minimal public bot example.
What Changed
npm run smoke:workerdto run the Worker with the installed baileyrs/hostentry under local Wrangler/workerd withoutnodejs_compat, checking unauthorized access and authenticated Durable Object status.Risk Assessment
✅ Low: The change adds a bounded consumer runtime smoke, and the prior scratch-directory defect is correctly fixed without expanding scope.
Testing
Installed dependencies and ran the packaged smoke twice in local workerd without Node compatibility. Captured successful Durable Object status and rejected authentication attempts. Paired-account recovery remains outside this smoke's scope. No UI changed.
Evidence: Fresh-checkout packaged workerd smoke
Evidence: Live HTTP responses
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
scripts/smoke-workerd.mjs:8- On a fresh checkout,.wranglerdoes not exist.mkdtempcreates only the final directory, so this throws ENOENT before Wrangler starts. The new CI workflow runs this exact sequence afternpm ci, preventing the required runtime smoke from executing. Create.wranglerwith recursive mkdir before calling mkdtemp.🔧 Fix applied.
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
Inspected the change, issue #4, and merged example PR #1 to establish consumer-side scope and prior validation limits.npm ci --no-audit --no-fundnpm run smoke:workerdwith no pre-existing .wrangler directoryRepeated the smoke through a fetch instrumentation wrapper, recording actual responses and asserting incorrect-token rejection on GET /status and POST /start.Removed generated WASM and scratch directory; confirmed no source changes.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.
Summary by cubic
Adds a workerd smoke check that runs the installed baileyrs
/hostentry withoutnodejs_compat, verifying the admin-token guard and Durable Object status route, and wires it into CI..wranglerdirectory before the scratch setup so the smoke script works on a fresh checkout.Written for commit 4ce792c. Summary will update on new commits.
Summary by CodeRabbit