PVerifier: handle choose in expression contexts to avoid internal codegen crash#972
Draft
Copilot wants to merge 3 commits into
Draft
PVerifier: handle choose in expression contexts to avoid internal codegen crash#972Copilot wants to merge 3 commits into
choose in expression contexts to avoid internal codegen crash#972Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix internal error using PVerifier on the tutorial example
PVerifier: handle Jun 1, 2026
choose in expression contexts to avoid internal codegen crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p compile --mode pverifiercould throw an internal error whenchoose(...)appeared inside a larger expression (notably tuple construction in the Two-Phase Commit tutorial client). The backend only handledChooseExprin a narrow assignment shape, so nested usage reached the unsupported-expression fallback.PVerifier expression coverage
ChooseExprhandling inExprToString(...):choose()lowers to nondet*choose(x)lowers to generated chooser call viaChooseExprHelper(...)Chooser declaration model update
procedure ... returns ... ensures ...tofunction ...+axiom forall ...constraints forint,set, andmapdomains.Assignment path alignment
AssignStmt { Value: ChooseExpr }emission to expression assignment form, with explicit handling forchoose().Regression coverage
PVerifierChooseExprTests) that exercises a named tuple containing nestedchoose(...)and asserts correct rendering behavior.