[eslint-plugin] Flag Popover as deprecated in favor of PopoverNext#8007
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Pull request overview
This PR updates the eslint-plugin deprecation rules to flag Popover usage and guide migrations to PopoverNext, aligning linting behavior with the component’s deprecation status.
Changes:
- Add
Popover -> PopoverNextto the core-components deprecation migration mapping. - Add invalid test cases to ensure
Popoveris reported by bothno-deprecated-core-componentsandno-deprecated-components. - Type the core migration mapping with
DeprecatedComponentsConfig.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/eslint-plugin/test/no-deprecated-core-components.test.ts | Adds invalid cases for Popover with both named and namespace imports. |
| packages/eslint-plugin/test/no-deprecated-components.test.ts | Adds an invalid case for Popover via named import. |
| packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-core-components.ts | Adds Popover migration mapping and types the mapping config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add lint rule to flag Popover usage in favor of PopoverNextBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
f275f7b to
d108454
Compare
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview✨ Features
|
Add lint rule to flag Popover usage in favor of PopoverNextBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Disable lint rule for existing Popover componentsBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
11549d1 to
567fa72
Compare
Add lint rule to flag Popover usage in favor of PopoverNextBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Ignore lint rule in existing Popover docs examplesBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Ignore lint rule in existing Popover demo examplesBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Merge branch 'develop' into gd/deprecated-popover-lint-ruleBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Summary
Adds
Popoverto theno-deprecated-core-componentsandno-deprecated-componentsESLint rules, suggesting migration toPopoverNext. This complements the JSDoc@deprecatedannotation added in #8006.The mapping uses the same-package string format since both components live in
@blueprintjs/core. Test cases cover named imports and namespace imports.