Skip to content

[eslint-plugin] Flag Popover as deprecated in favor of PopoverNext#8007

Merged
ggdouglas merged 4 commits into
developfrom
gd/deprecated-popover-lint-rule
Jun 3, 2026
Merged

[eslint-plugin] Flag Popover as deprecated in favor of PopoverNext#8007
ggdouglas merged 4 commits into
developfrom
gd/deprecated-popover-lint-rule

Conversation

@ggdouglas
Copy link
Copy Markdown
Contributor

Summary

Adds Popover to the no-deprecated-core-components and no-deprecated-components ESLint rules, suggesting migration to PopoverNext. This complements the JSDoc @deprecated annotation added in #8006.

The mapping uses the same-package string format since both components live in @blueprintjs/core. Test cases cover named imports and namespace imports.

Copilot AI review requested due to automatic review settings April 2, 2026 02:52
@changelog-app
Copy link
Copy Markdown

changelog-app Bot commented Apr 2, 2026

Generate changelog in packages/eslint-plugin/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

[eslint-plugin] Flag Popover as deprecated in favor of PopoverNext

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the eslint-plugin deprecation rules to flag Popover usage and guide migrations to PopoverNext, aligning linting behavior with the component’s deprecation status.

Changes:

  • Add Popover -> PopoverNext to the core-components deprecation migration mapping.
  • Add invalid test cases to ensure Popover is reported by both no-deprecated-core-components and no-deprecated-components.
  • Type the core migration mapping with DeprecatedComponentsConfig.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
packages/eslint-plugin/test/no-deprecated-core-components.test.ts Adds invalid cases for Popover with both named and namespace imports.
packages/eslint-plugin/test/no-deprecated-components.test.ts Adds an invalid case for Popover via named import.
packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-core-components.ts Adds Popover migration mapping and types the mapping config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/eslint-plugin/test/no-deprecated-core-components.test.ts
Comment thread packages/eslint-plugin/test/no-deprecated-core-components.test.ts
Comment thread packages/eslint-plugin/test/no-deprecated-components.test.ts
Comment thread packages/eslint-plugin/test/no-deprecated-components.test.ts
@blueprint-previews
Copy link
Copy Markdown

Add lint rule to flag Popover usage in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gd/deprecated-popover-lint-rule branch from f275f7b to d108454 Compare April 7, 2026 18:49
@changelog-app
Copy link
Copy Markdown

changelog-app Bot commented Apr 7, 2026

Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

✨ Features

  • [eslint-plugin] Flag Popover as deprecated in favor of PopoverNext (#8007)

@blueprint-previews
Copy link
Copy Markdown

Add lint rule to flag Popover usage in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@blueprint-previews
Copy link
Copy Markdown

Disable lint rule for existing Popover components

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gd/deprecated-popover-lint-rule branch from 11549d1 to 567fa72 Compare June 1, 2026 19:29
@blueprint-previews
Copy link
Copy Markdown

Add lint rule to flag Popover usage in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@blueprint-previews
Copy link
Copy Markdown

Ignore lint rule in existing Popover docs examples

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@blueprint-previews
Copy link
Copy Markdown

Ignore lint rule in existing Popover demo examples

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@blueprint-previews
Copy link
Copy Markdown

Merge branch 'develop' into gd/deprecated-popover-lint-rule

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit c004f3c into develop Jun 3, 2026
15 checks passed
@ggdouglas ggdouglas deleted the gd/deprecated-popover-lint-rule branch June 3, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants