[select] Fix Select not respecting shouldDismissPopover={false} on Enter

packages/select/src/components/select/select.test.tsx

@@ -200,6 +200,29 @@ describe("<Select>", () => {
         expect(wrapper.find(Popover).prop("isOpen")).toBe(true);
     });
 
+    it("does not close the popover when selecting via Enter on a MenuItem with shouldDismissPopover={false}", () => {
+        const itemRenderer = (film: Film, { handleClick, handleFocus, modifiers }: any) => {
+            return (
+                <MenuItem
+                    active={modifiers.active}
+                    onClick={handleClick}
+                    onFocus={handleFocus}
+                    text={`${film.rank}. ${film.title}`}
+                    shouldDismissPopover={false}
+                />
+            );
+        };
+        const wrapper = select({ itemRenderer, popoverProps: { usePortal: false } });
+
+        findTargetButton(wrapper).simulate("click");
+        expect(wrapper.find(Popover).prop("isOpen")).toBe(true);
+
+        // simulate keyboard selection: Enter on the input element
+        wrapper.find("input").simulate("keydown", { key: "Enter" });
+        wrapper.find("input").simulate("keyup", { key: "Enter" });
+        expect(wrapper.find(Popover).prop("isOpen")).toBe(true);
+    });
+
     function select(props: Partial<SelectProps<Film>> = {}, query?: string) {
         const wrapper = mount(
             <Select<Film> {...defaultProps} {...handlers} {...props}>

packages/select/src/components/select/select.tsx

@@ -306,8 +306,13 @@ export class Select<T> extends AbstractPureComponent<SelectProps<T>, SelectState
     };
 
     private handleItemSelect = (item: T, event?: React.SyntheticEvent<HTMLElement>) => {
-        const target = event?.target as HTMLElement;
-        const menuItem = target?.closest(`.${CoreClasses.MENU_ITEM}`);
+        const target = event?.target as HTMLElement | undefined;
+        // When selection is triggered via keyboard (Enter), event.target is the input element,
+        // not the menu item. Fall back to looking up the active menu item in the document so
+        // that `shouldDismissPopover={false}` is respected in both click and keyboard flows.
+        const menuItem =
+            target?.closest(`.${CoreClasses.MENU_ITEM}`) ??
+            (target?.ownerDocument ?? document).querySelector(`.${CoreClasses.MENU_ITEM}.${CoreClasses.ACTIVE}`);
         const menuItemDismiss = menuItem?.matches(`.${CoreClasses.POPOVER_DISMISS}`);
         const shouldDismiss = menuItemDismiss ?? true;