Accept ReadonlyArray<T> for items and more in Select#8108
Open
braeden wants to merge 1 commit into
Open
Conversation
Widen `items`, `selectedItems`, `filteredItems`, and related callback parameters in `@blueprintjs/select` to accept `ReadonlyArray<T>` so consumers can pass readonly arrays without copying. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Generate changelog in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extremely common to have to cast
asMutableArraybefore theSelectorMultiSelectboundary.The proposal here is to widen the types of
items,selectedItems,filteredItems, and related callback parameters in@blueprintjs/selectto accept `ReadonlyArray.Although the direct
items, props are not a breaking change (since it's more widely assignable), it's possible to create a mutating callback that will be a break when encounteringReadonlyArray<T>instead ofT[]. See hownavigator.tsxgot changed.I think this is still desirable change & aligns closely with semantics of new reference equality -> render that React sticks too.