Skip to content

(chore) allow blueprint team members to self-approve PRs #8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameronjoyner wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

(chore) allow blueprint team members to self-approve PRs #8111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .policy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ policy:
approval:
- or:
# Blueprint team members - trusted
- blueprint team member self-approval
- blueprint team member approved by one admin
- blueprint team member approved by two admins (contributor allowed)
# External contributors - stricter
Expand All @@ -28,6 +29,21 @@ approval_rules:
# BLUEPRINT TEAM MEMBERS (trusted)
# ============================================

- name: blueprint team member self-approval
description: >
For PRs authored by Blueprint team members. Allows the author to approve
their own PR (self-approval).
options:
allow_contributor: true
invalidate_on_push: false
ignore_edited_comments: true
if:
has_author_in:
teams: ["palantir/blueprint"]
requires:
count: 1
permissions: ["admin", "maintain"]

- name: blueprint team member approved by one admin
description: >
For PRs authored by Blueprint team members. Approvals are not invalidated
Expand Down