Skip to content

remove pre-initialization of concat-dim - #236

Merged
rabernat merged 1 commit into
pangeo-forge:masterfrom
rabernat:remove-pre-initialization
Nov 29, 2021
Merged

remove pre-initialization of concat-dim#236
rabernat merged 1 commit into
pangeo-forge:masterfrom
rabernat:remove-pre-initialization

Conversation

@rabernat

Copy link
Copy Markdown
Contributor

This PR will test the new slash command workflows introduced in #234.

@rabernat

Copy link
Copy Markdown
Contributor Author

/run-test-tutorials

2 similar comments
@rabernat

Copy link
Copy Markdown
Contributor Author

/run-test-tutorials

@rabernat

Copy link
Copy Markdown
Contributor Author

/run-test-tutorials

@cisaacstern

Copy link
Copy Markdown
Member

If the notebooks are run in CI, why is there a slash command?

@rabernat

Copy link
Copy Markdown
Contributor Author

/run-test-tutorials

@rabernat

Copy link
Copy Markdown
Contributor Author

If the notebooks are run in CI, why is there a slash command?

Because I don't want the notebooks tests to run every time you push to a PR. I want them to run on command.

@rabernat

Copy link
Copy Markdown
Contributor Author

This is now basically working right but reveals two problems.

@cisaacstern

Copy link
Copy Markdown
Member

The text pre-commit is appended in front of the check name. I have no idea why.

🙃 ... IIUC strings w/out special characters don't need enclosing quotes in YAML but the action example uses them for name: and seems to get the desired result, whereas this PR does not 🤷

@rabernat

Copy link
Copy Markdown
Contributor Author

/run-test-tutorials

Trying with change to bot permissions from 9039dbf (recommended in LouisBrunner/checks-action#18 (comment))

@rabernat

Copy link
Copy Markdown
Contributor Author

This seems to work. I'm going to merge it.

@rabernat
rabernat merged commit aad2f0f into pangeo-forge:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants