Move Buf subsystem out of the lint subpackage#23382
Merged
Merged
Conversation
Hoists `subsystem.py` and `skip_field.py` from `backend/codegen/protobuf/lint/buf/` up to `backend/codegen/protobuf/buf/` so non-lint consumers (e.g. an upcoming buf-based code generator) can depend on the Buf subsystem without reaching into the lint package. Pure file relocation plus import path updates; no behavior change.
cburroughs
added
the
release-notes:not-required
cburroughs
approved these changes
May 29, 2026
cburroughs
left a comment
cburroughs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for breaking this out! (I think to be pedantic this should get a brief mention in the plugin api section of the release notes but I think it is fine -- better even! -- to fold that into the upcoming changes.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hoists
subsystem.pyandskip_field.pyfromsrc/python/pants/backend/codegen/protobuf/lint/buf/up tosrc/python/pants/backend/codegen/protobuf/buf/so non-lint consumers can depend on theBufSubsystemwithout reaching into the lint package.Pure file relocation —
git mvof two files plus import-path updates in the three files that referenced them. No behavior change.This is split out from #23343 (which adds Buf as an alternate Python protobuf code generator) to make that PR easier to review by separating the mechanical move from the substantive new code. Once this lands, #23343 will be rebased onto it and reduce to just the codegen feature.
Test plan
./pants test src/python/pants/backend/codegen/protobuf/lint/buf::still passes (lint/format rules import from new path).