Fix scalac plugin paths in BSP options response#23564
Open
alexanderheldt wants to merge 1 commit into
Open
Conversation
The BSP buildTarget/scalacOptions handler emitted -Xplugin: arguments using a digest-relative prefix, producing relative paths that BSP clients could not resolve. The plugin jars are materialized under .pants.d/bsp in the workspace, so emit absolute paths there instead, matching the classpath and class_directory fields in the same response.
alexanderheldt
force-pushed
the
fix-bsp-scalac-plugin-paths
branch
from
July 23, 2026 13:52
5bf9c1e to
4daf37e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_bsp_scalac_options_requestputscalacplugin jars under.pants.d/bsp/, but emits the-Xplugin:options relative to the build root:while the jars actually are in
.pants.d/bsp/jvm/resolves/scala213/plugins, so there is a mismatch here which causes BSP to not find e.g. semanticdb which causes metals to logI tested this locally with my pants fork and the fix ensures semanticdb is loaded correctly when using metals.
LLM usage note: Had an LLM write the docs summary for me