Skip to content

fix: Add logical replication error details to chart alerts - #269

Closed
philippemnoel wants to merge 1 commit into
devfrom
feat/replication-alert-details
Closed

philippemnoel wants to merge 1 commit into
devfrom
feat/replication-alert-details

Conversation

@philippemnoel

Copy link
Copy Markdown
Member

What

Add separate five-minute apply_errors and sync_errors annotations to both logical-replication error alerts, plus a logs_url pointing to the existing subscriber-log diagnosis. This brings the chart's alert details in line with paradedb/mcc#317.

Why

The combined count does not tell operators whether errors occurred during normal replication or initial table synchronization. Notification templates can now display both counts for each affected subscription.

How

Scope annotation queries to the alert's namespace, job, subscription, and the chart's cluster-pod selector. Keep existing expressions, thresholds, durations, and labels unchanged. Document per-alert rendering for grouped notifications and the per-pod maximum/failover semantics of the counts. The OnCall Slack template remains MCC-specific.

Chart versions are generated by the publishing workflow, so no static version bump is needed.

Tests

  • helm lint with monitoring and PrometheusRule enabled passed.
  • Ran the full prometheus-rule-rendering script locally, including existing rendering checks and exclusion of both error rules.
  • Added and passed vmalert-tool v1.148.0 tests against Helm-rendered rules: mixed apply/sync errors, sync-only errors, healthy subscriptions, and isolation by subscription, job, namespace, and cluster pods. Wired the test tool into the existing rendering CI job.
  • git diff --check passed.

The Kubernetes integration suite remains for CI. No deployment or notification configuration was changed.

@philippemnoel
philippemnoel changed the base branch from main to dev September 26, 2026 01:37
@philippemnoel
philippemnoel force-pushed the dev branch 2 times, most recently from 3448db7 to c01e6b2 Compare October 5, 2026 03:37
@philippemnoel
philippemnoel force-pushed the feat/replication-alert-details branch from fd4736c to e6882b7 Compare October 5, 2026 03:46
@philippemnoel
philippemnoel deleted the feat/replication-alert-details branch October 5, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant