fix: Add logical replication error details to chart alerts - #269
Closed
philippemnoel wants to merge 1 commit into
Closed
philippemnoel wants to merge 1 commit into
philippemnoel wants to merge 1 commit into
Conversation
philippemnoel
force-pushed
the
dev
branch
2 times, most recently
from
October 5, 2026 03:37
3448db7 to
c01e6b2
Compare
philippemnoel
force-pushed
the
feat/replication-alert-details
branch
from
October 5, 2026 03:46
fd4736c to
e6882b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add separate five-minute
apply_errorsandsync_errorsannotations to both logical-replication error alerts, plus alogs_urlpointing to the existing subscriber-log diagnosis. This brings the chart's alert details in line with paradedb/mcc#317.Why
The combined count does not tell operators whether errors occurred during normal replication or initial table synchronization. Notification templates can now display both counts for each affected subscription.
How
Scope annotation queries to the alert's namespace, job, subscription, and the chart's cluster-pod selector. Keep existing expressions, thresholds, durations, and labels unchanged. Document per-alert rendering for grouped notifications and the per-pod maximum/failover semantics of the counts. The OnCall Slack template remains MCC-specific.
Chart versions are generated by the publishing workflow, so no static version bump is needed.
Tests
helm lintwith monitoring and PrometheusRule enabled passed.prometheus-rule-renderingscript locally, including existing rendering checks and exclusion of both error rules.git diff --checkpassed.The Kubernetes integration suite remains for CI. No deployment or notification configuration was changed.