Always remove stale abi json file#88
Merged
Merged
Conversation
Benchmark Size Comparison (vs main)
OK: All artifacts within 5% regression thresholdRun 26757614686 | d7b18e3 | 2026-06-01 13:33 UTC |
smiasojed
reviewed
Jun 1, 2026
smiasojed
pushed a commit
that referenced
this pull request
Jun 2, 2026
* always remove stale abi json file * nit + comments * improve error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes https://github.com/paritytech/bugbounty_reports/issues/78
process_elf_binariesnow removes any previous .abi.json immediately after writing the new .polkavm, so a .polkavm overwrite never leaves a stale ABI behind.Adds two regression tests covering the macro-stripped rebuild and a no-op rebuild byte-stability check. See paritytech/bugbounty_reports#78 for full context.