-
Notifications
You must be signed in to change notification settings - Fork 6
Add polkadot-bulletin-chain as submodule #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mudigal
wants to merge
14
commits into
main
Choose a base branch
from
nm-bulletin-submodule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0c7244a
Add polkadot-bulletin-chain as submodule
mudigal 5bdec16
Replace Bulletin chainspec files with symlinks to submodule
mudigal 5d76cc3
Add Bulletin to README for Polkadot, Paseo, and Westend
mudigal 72ae462
Retarget symlinks to flat layout and bump submodule
x3c41a 932cc3f
Remove stale submodules/watr gitlink
x3c41a c74a8e5
Remove leftover polkadot/parachain/watr broken symlink
x3c41a 00fda23
README: split Paseo Bulletin into Next and Next v2
x3c41a 671af5e
Update README.md
x3c41a a76f695
Merge branch 'main' into nm-bulletin-submodule
bkontur 805597a
Rename paseo bulletin directories to bulletin-next and bulletin-next-v2
x3c41a 09cc802
Remove raw.json and genesis-head for bulletin parachains
x3c41a 5f2dbb7
Revert "Remove leftover polkadot/parachain/watr broken symlink"
x3c41a 923d535
Revert "Remove stale submodules/watr gitlink"
x3c41a 7288411
Merge branch 'main' into nm-bulletin-submodule
nprt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../submodules/polkadot-bulletin-chain/chainspecs/paseo-next-v2-chainspec.json |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../submodules/polkadot-bulletin-chain/chainspecs/paseo-next-chainspec.json |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../submodules/polkadot-bulletin-chain/chainspecs/polkadot-chainspec.json |
This file was deleted.
Oops, something went wrong.
Submodule polkadot-bulletin-chain
added at
273b18
Submodule watr
deleted from
12f372
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../submodules/polkadot-bulletin-chain/chainspecs/westend-chainspec.json |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@x3c41a I think think
paseo/parachain/bulletin/chainspec.jsonis not obvious which paseo are we talking about. I would keep the "convention".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, also align subfolder:
paseo/parachain/bulletin/chainspec.json -> paseo/parachain/bulletin-next/chainspec.json
paseo/parachain/bulletin-next/chainspec.json -> paseo/parachain/bulletin-next-v2/chainspec.json