Skip to content

Replace unwrap/expect with proper error propagation #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimartiro wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Replace unwrap/expect with proper error propagation #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fe115a
Replace unwrap/expect with proper error propagation
dimartiro Feb 10, 2026
73144f3
fmt
dimartiro Feb 19, 2026
78d4f55
avoid_panics: Propagate errors in dial and webrtc transport setup
dimartiro Jun 1, 2026
a63e2eb
Limit scope to webrtc: revert quic/s2n-quic/noise error-propagation c…
dimartiro Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/transport/webrtc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,19 +416,18 @@ impl WebRtcTransport {
);

// create new `Rtc` object for the peer and give it the received STUN message
let (mut rtc, noise_channel_id) =
self.make_rtc_client(ufrag, pass, source, self.socket.local_addr().unwrap());
let local_addr = self.socket.local_addr()?;
let (mut rtc, noise_channel_id) = self.make_rtc_client(ufrag, pass, source, local_addr);

rtc.handle_input(Input::Receive(
Instant::now(),
Receive {
source,
proto: Str0mProtocol::Udp,
destination: self.socket.local_addr().unwrap(),
destination: local_addr,
contents,
},
))
.expect("client to handle input successfully");
))?;

let connection_id = self.context.next_connection_id();
let connection = OpeningWebRtcConnection::new(
Expand Down Expand Up @@ -498,7 +497,7 @@ impl TransportBuilder for WebRtcTransport {

const MULTIHASH_SHA256_CODE: u64 = 0x12;
let certificate = Multihash::wrap(MULTIHASH_SHA256_CODE, &fingerprint)
.expect("fingerprint's len to be 32 bytes");
.map_err(|_| Error::InvalidData)?;

vec![Multiaddr::empty()
.with(Protocol::from(listen_address.ip()))
Expand Down
4 changes: 2 additions & 2 deletions src/transport/webrtc/opening.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,13 @@ impl OpeningWebRtcConnection {
.rtc
.direct_api()
.remote_dtls_fingerprint()
.expect("fingerprint to exist")
.ok_or(Error::InvalidState)?
.clone()
.bytes;

let certificate =
multihash::Multihash::<64>::wrap(Code::Sha2_256.into(), &remote_fingerprint)
.expect("fingerprint's len to be 32 bytes");
.map_err(|_| Error::InvalidData)?;

let address = Multiaddr::empty()
.with(Protocol::from(self.peer_address.ip()))
Expand Down