perf(transport): Optimize protocol name construction on substream open#607
Open
dimartiro wants to merge 1 commit into
Open
perf(transport): Optimize protocol name construction on substream open#607dimartiro wants to merge 1 commit into
dimartiro wants to merge 1 commit into
Conversation
13645bf to
22ba4c9
Compare
Collaborator
|
@dimartiro Thanks a lot for contributing! This conflcts pending webrtc work, we'll dedicate a separate review once we stabilize the transport layer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protocol negotiation lists were rebuilt on every substream open even though they are static after handler initialization. Precompute them once and share via
Arc:TransportServiceprecomputesArc<[ProtocolName]>for outbound protocols;ProtocolSetexposesArc<HashMap<...>>for the keep-alive map.ProtocolCommand::OpenSubstreamcarries the sharedArcinstead of the duplicated(protocol, fallback_names)pair.negotiate_protocolis generic overIntoIteratorand iterates theArc'd lists directly.WebRtcDialerStatestoresArc<[ProtocolName]>+ cursor;webrtc_listener_negotiateacceptsIntoIterator<Item = &ProtocolName>.Closes #346