Staking-async heavy blocks work with basti-blocks#10895
Closed
kianenigma wants to merge 272 commits into
Closed
Conversation
…-audience node_dev'
…om:paritytech/polkadot-sdk into bkchr-parachain-block-data-multiple-blocks
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
…ck-data-multiple-blocks
…ck-data-multiple-blocks
…ignore-trie-nodes
kianenigma
commented
Feb 25, 2026
| let remaining_weight = remaining_weight_meter.remaining(); | ||
| let can_execute = remaining_weight.all_gte(combined_weight); | ||
|
|
||
| // TODO: the above doesn't work because the `remaining_block_weight` is already the |
Contributor
Author
There was a problem hiding this comment.
@bkchr just came across this, I should have raised this earlier. This is the main blocker right now to implement this simple fix for the staking heavy blocks.
Contributor
Author
|
Replaced by #12202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is on top of #10477
It demonstrates the changes necessary to implement the simple solution mentioned in #10143
FullCoreblock weight, but it is easy to fix it.