cumulus-test-runtime: move feature-gated params into flavor module#12129
Closed
Kanasjnr wants to merge 4 commits into
Closed
cumulus-test-runtime: move feature-gated params into flavor module#12129Kanasjnr wants to merge 4 commits into
Kanasjnr wants to merge 4 commits into
Conversation
Contributor
Author
|
/cmd label T9-cumulus T10-tests I4-refactor R0-no-crate-publish-required |
Contributor
Author
|
/cmd prdoc --audience node_dev |
paritytech-cmd-bot-polkadot-sdk
Bot
added
I4-refactor
Only import BLOCK_PROCESSING_VELOCITY and RELAY_PARENT_OFFSET when the default-backing unincluded segment capacity constant is compiled.
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
cumulus-test-runtimeso feature-gated parameters live in a dedicatedflavor/module tree instead of scattered#[cfg(...)]blocks inlib.rs.src/flavor/with modules for block velocity, slot duration, relay parent offset, unincluded segment capacity, relay chain slot duration, and Aura backing behavior.lib.rsto import fromflavor/; keepVERSIONinlib.rs(required by#[sp_version::runtime_version]).Closes #11991.
Motivation
The test runtime is built many times with different Cargo features (elastic scaling, sync/async backing, relay-parent offset, block-bundling, etc.). Constants that depend on those features were hard to follow and extend in
lib.rs. Grouping them by concern makes it easier to see which feature enables which values and to add new flavors later.