fix(child-bounties): fix curator assignment bugs in unassign and award (RWF)#12195
Open
messiawrq-design wants to merge 1 commit into
Open
fix(child-bounties): fix curator assignment bugs in unassign and award (RWF)#12195messiawrq-design wants to merge 1 commit into
messiawrq-design wants to merge 1 commit into
Conversation
…d (RWF) Fixes paritytech#12192: `unassign_curator` can return a child bounty to `Added` status without subtracting the child curator fee from `ChildrenCuratorFees`. This PR adds the missing mutation to ensure parent-bounty accounting is not inflated after the unassignment. Fixes paritytech#12190: When a parent curator awards an active child bounty, the pallet incorrectly records the parent curator (the `signer`) as the `PendingPayout.curator` instead of preserving the child-bounty curator. This PR fixes it by using `curator.clone()` instead of `signer`. Bounty Wallet: 6sF8p22Gg83NKTJ6dvya7Srv4USCniZnP47DwQwK7Mtp (Solana) / Algora
|
User @messiawrq-design, please sign the CLA here. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12192:
unassign_curatorcan return a child bounty toAddedstatus without subtracting the child curator fee fromChildrenCuratorFees.This PR adds the missing mutation to ensure parent-bounty accounting is not inflated after the unassignment.
Fixes #12190: When a parent curator awards an active child bounty, the pallet incorrectly records the parent curator (the
signer) as thePendingPayout.curatorinstead of preserving the child-bounty curator.This PR fixes it by using
curator.clone()instead ofsigner.Bounty Wallet: 6sF8p22Gg83NKTJ6dvya7Srv4USCniZnP47DwQwK7Mtp (Solana)