pallet-revive eth-rpc: make SubmittedTransaction::gas() return Option<U256>#12220
Open
Nathy-bajo wants to merge 4 commits into
Open
pallet-revive eth-rpc: make SubmittedTransaction::gas() return Option<U256>#12220Nathy-bajo wants to merge 4 commits into
Nathy-bajo wants to merge 4 commits into
Conversation
Contributor
Author
|
/cmd prdoc --audience node_dev --bump major |
Contributor
Author
|
/cmd label T7-smart_contracts |
…e_dev --bump major'
paritytech-cmd-bot-polkadot-sdk
Bot
added
the
T7-smart_contracts
Contributor
Author
|
@0xOmarA @marian-radu @athei This is ready for review also |
xermicus
reviewed
May 28, 2026
| Change `SubmittedTransaction::gas()` to return `Option<U256>` mirroring the underlying `GenericTransaction::gas` field, and skip the `wait_for_receipt` gas-limit assertion when no gas limit is set, removing the panic that occurred on legacy/incomplete payloads. | ||
| crates: | ||
| - name: pallet-revive-eth-rpc | ||
| bump: major |
Member
There was a problem hiding this comment.
I'm surprised that this example code module is even public. @pgherveou do you know any reason?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11889
Change
SubmittedTransaction::gas()to returnOption<U256>mirroring the underlyingGenericTransaction::gasfield, and skip thewait_for_receiptgas-limit assertion when no gas limit is set, removing the panic that occurred on legacy/incomplete payloads.