-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cumulus test runtime: fix + cleanup #12231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serban300
merged 10 commits into
paritytech:master
from
serban300:cumulus-test-runtime-cleanup
Jun 4, 2026
+207
−235
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5eef742
Fix cumulus test runtime
serban300 cecd9ca
cumulus test runtime: remove unneeded flavor
serban300 f5d4e86
cumulus test runtime: cleanup configs
serban300 6b729ef
Remove "fallback-target-block-rate" feature
serban300 e6f3a74
CR comments
serban300 5eb898d
fix
serban300 f0829f4
CR comments
serban300 42dbf65
Try remove rpo from unincluded segment capacity
serban300 c1d1b3a
undo scheduling v3 test expected throughput
serban300 650fc0c
Apply CR suggestion
serban300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,99 +18,80 @@ | |
| fn main() { | ||
| use substrate_wasm_builder::WasmBuilder; | ||
|
|
||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("async-backing") | ||
| .import_memory() | ||
| .build(); | ||
| // A runtime with 6s slot duration which only authors one block per slot. | ||
| WasmBuilder::init_with_defaults().build(); | ||
|
|
||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("increment-spec-version") | ||
| .set_file_name("wasm_binary_spec_version_incremented.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("elastic-scaling") | ||
| .import_memory() | ||
| .set_file_name("wasm_binary_elastic_scaling_mvp.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("elastic-scaling") | ||
| .import_memory() | ||
| .enable_feature("velocity-3") | ||
| .enable_feature("increment-spec-version") | ||
| .set_file_name("wasm_binary_elastic_scaling.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("elastic-scaling-500ms") | ||
| .import_memory() | ||
| // A runtime with low slot duration of 500ms for low-latency testing with 12 cores. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment is wrong? Because this only enables 12 blocks, but doesn't change the slot time?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("velocity-12") | ||
| .set_file_name("wasm_binary_elastic_scaling_500ms.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("elastic-scaling-multi-block-slot") | ||
| .import_memory() | ||
| // A runtime with a slot duration of 6s but parameters that allow multiple blocks per slot. | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("velocity-6") | ||
| .set_file_name("wasm_binary_elastic_scaling_multi_block_slot.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("relay-parent-offset") | ||
| .import_memory() | ||
| // A runtime that uses a relay parent offset of 2. | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("relay-parent-offset-2") | ||
| .set_file_name("wasm_binary_relay_parent_offset.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("sync-backing") | ||
| .import_memory() | ||
| .enable_feature("12s-slot") | ||
| .set_file_name("wasm_binary_sync_backing.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("elastic-scaling-12s-slot") | ||
| .enable_feature("elastic-scaling") | ||
| .import_memory() | ||
| // An elastic scaling runtime with 12s slots. | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("12s-slot") | ||
| .enable_feature("velocity-3") | ||
| .enable_feature("increment-spec-version") | ||
| .set_file_name("wasm_binary_elastic_scaling_12s_slot.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("block-bundling") | ||
| .import_memory() | ||
| // A runtime that uses block-bundling. | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("velocity-12") | ||
| .set_file_name("wasm_binary_block_bundling.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("async-backing") | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("v3-descriptor") | ||
| .import_memory() | ||
|
serban300 marked this conversation as resolved.
Outdated
|
||
| .set_file_name("wasm_binary_async_backing_v3.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
|
serban300 marked this conversation as resolved.
Outdated
|
||
| .enable_feature("async-backing") | ||
| .enable_feature("v3-descriptor") | ||
| .enable_feature("relay-parent-offset") | ||
| .import_memory() | ||
| .enable_feature("relay-parent-offset-2") | ||
| .set_file_name("wasm_binary_async_backing_v3_rpo.rs") | ||
| .build(); | ||
|
|
||
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .enable_feature("elastic-scaling") | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("v3-descriptor") | ||
| .import_memory() | ||
| .enable_feature("velocity-3") | ||
| .set_file_name("wasm_binary_elastic_scaling_v3.rs") | ||
| .build(); | ||
|
|
||
| // A runtime with 18s slot duration with increased spec version for runtime upgrade testing. | ||
| WasmBuilder::init_with_defaults() | ||
| .enable_feature("slot-duration-18s") | ||
| .enable_feature("18s-slot") | ||
| .enable_feature("increment-spec-version") | ||
| .set_file_name("wasm_binary_slot_duration_18s.rs") | ||
| .build(); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comments on what they are doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done