Skip to content

pallet-dap: re-export WeightInfo at crate root#12246

Merged
sigurpol merged 3 commits into
masterfrom
sigurpol-fix-dap-export-weight
Jun 1, 2026
Merged

pallet-dap: re-export WeightInfo at crate root#12246
sigurpol merged 3 commits into
masterfrom
sigurpol-fix-dap-export-weight

Conversation

@sigurpol
Copy link
Copy Markdown
Contributor

@sigurpol sigurpol commented Jun 1, 2026

The trait was only reachable at pallet_dap::weights::WeightInfo, so the benchmark template's generated pallet_dap::WeightInfo path failed to resolve and required a manual fixup in every consumer. Add the standard FRAME re-export (pub use weights::WeightInfo;) and switch the Asset Hub Westend weights file and the staking-async integration test back to the canonical pallet_dap::WeightInfo path.

The trait was only reachable at `pallet_dap::weights::WeightInfo`, so the
benchmark template's generated `pallet_dap::WeightInfo` path failed to
resolve and required a manual fixup in every consumer. Add the standard
FRAME re-export (`pub use weights::WeightInfo;`) and switch the Asset Hub
Westend weights file and the staking-async integration test back to the
canonical `pallet_dap::WeightInfo` path.
@sigurpol sigurpol requested a review from a team as a code owner June 1, 2026 13:39
@sigurpol sigurpol added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Jun 1, 2026
@sigurpol
Copy link
Copy Markdown
Contributor Author

sigurpol commented Jun 1, 2026

/cmd prdoc --audience runtime_dev --bump patch

@sigurpol sigurpol requested review from andreitrand, cirko33, ggwpez and kianenigma and removed request for a team June 1, 2026 13:40
@sigurpol sigurpol requested a review from Ank4n June 1, 2026 13:46
@sigurpol sigurpol enabled auto-merge June 1, 2026 13:54
@sigurpol sigurpol added this pull request to the merge queue Jun 1, 2026
Merged via the queue into master with commit e5d5a28 Jun 1, 2026
387 of 412 checks passed
@sigurpol sigurpol deleted the sigurpol-fix-dap-export-weight branch June 1, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants