changes to use zombie-bite#12247
Open
pepoviola wants to merge 3 commits into
Open
Conversation
pepoviola
added
T10-tests
Contributor
Author
|
/cmd prdoc --audience node_operator --bump patch |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
…e_operator --bump patch'
Contributor
|
why is this needed? what's the reasoning behind the change |
Contributor
Author
We needed since we wrap the blockImport with doppelganger and override the gap sync (to not sync the past blocks), so if we scrape more blocks we get runtimeApi error and the resulting chain doesn't finalize more blocks. I'm not sure if we can disable this in way that doesn't need changes in the binary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use zombie-bite (to fork and spawn a live network with the state) with the same client binaries (for testing releases), we need to allow to set this value
DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATIONto 1. I think the best approach here is to use an env var, since we only need it for our use case. Cc @eskimor wdyt?Thx!