[asset-hubs/bridge-hubs] Bridging Polkadot Asset Hub <-> Kusama Asset Hub to enable asset transfer of KSMs/DOTs by bkontur · Pull Request #1352 · paritytech/polkadot-sdk

bkontur · 2023-09-01T13:01:27Z

Summary

Adding bridging capabilities to the Polkadot and Kusama Bridge Hub runtimes and XCM routing configuration for bridging between Polkadot Asset Hub <-> Kusama Asset Hub in order to allow asset transfer between Asset Hubs.

Motivation

Main goal of these changes is to setup bridge between system parachains Kusama Asset Hub vs Polkadot Asset Hub. We explicitly allow only reserve based transfer for KSM/DOT to cross-consensus AssetHubs and nothing else at first (start defensively). We can later allow whatever (ETH, TrustBackedAssets, ForeignAssets, PoolAssets ...).

Explanation

Please, check first four commits with detailed description

Testing

Adds tests for simulation:

limited_reserve_transfer_assets with pallet_xcm both ways
handling ReserveAssetDeposisted on both sides
handling ExportMessage on both sides
handling message dispatch and routing to target on both side
relayer can submit proofs with submit_finality_proof / submit_parachain_heads and relay messages with receive_messages_proof

Adds local zombienet run for:

reserve based transfer of KSMs from AHK to AHP
reserve based transfer of DOTs from AHP to AHK

(check parachains/runtimes/bridge-hubs/README.md in this PR)

Future Directions and Related Material

Next stage will be focused on adding support to allow bridging between arbitrary parachains More about Bridges V2.

More about dynamic fees and back-preasure for v1 can be found here.

This is a migration (without commit history) of original PRs in cumulus:

TODO

finish migration
fix cumulus/parachains/runtimes/bridge-hubs/README.md for local run
update description (collect all relevant information from migrated PRs)
add integration tests with xcm-emulator
migrate/open PR with runtime modifications to polkadot-fellows Migrate asset transfer over bridge to polkadot-fellows parity-bridges-common#2541

Add xcm routing configuration for bridging between Polkadot Asset Hub <-> Kusama Asset Hub. We explicitly allow only reserve based transfer for KSM/DOT to cross-consensus AssetHubs and nothing else at first (start defensively). We can later allow whatever (ETH, TrustBackedAssets, ForeignAssets, PoolAssets ...). Add tests for simulation: - `limited_reserve_transfer_assets` with `pallet_xcm` both ways - handling `ReserveAssetDeposisted` on both sides Add local zomienet run for: - reserve based transfer of KSMs from AHK to AHP - reserve based transfer of DOTs from AHP to AHK (check parachains/runtimes/bridge-hubs/README.md in this PR) Signed-off-by: Branislav Kontur <bkontur@gmail.com> Signed-off-by: Adrian Catangiu <adrian@parity.io>

Change XCM routing configuration for bridging from unpaid to paid version. Paid version means that origin (besides extrinsic fees) pays delivery fees at source Asset Hub and also Asset Hub sovereign account pays for execution of `ExportMessage` instruction at local Bridge Hub. Change XCM bridging router from `UnpaidRemoteExporter` to `ToPolkadotXcmRouter` and `ToKusamaXcmRouter` which are pallet instances of new module `pallet-xcm-bridge-hub-router`. The main thing that the pallet `pallet-xcm-bridge-hub-router` offers is the dynamic message fee, that is computed based on the bridge queues state. It starts exponentially increasing if the queue between this chain and the sibling/child bridge hub is congested. More about dynamic fees and back-preasure for v1 can be found [here](paritytech/parity-bridges-common#2294). Signed-off-by: Branislav Kontur <bkontur@gmail.com> Signed-off-by: Adrian Catangiu <adrian@parity.io> Signed-off-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>

…lay, para) chains Add bridging pallets to Bridge Hub runtime configuration: - `pallet-bridge-grandpa` is an on-chain GRANDPA light client, used for verifying GRANDPA finality proofs on-chain. - `pallet-bridge-parachains` is a Parachain finality module. - `pallet-bridge-messages` module that allows sending and receiving messages using lane concept. - `pallet-bridge-relayers` module that is used to store relayer rewards. Kusma Bridge Hub and Polkadot Bridge Hub runtimes are configred with those pallets in the way that: - allows to verify bridged relay chain GRANDPA finality proofs, e.g. Kusama Bridge Hub can track and verify Polkadot relay chain GRANDPA proofs and Polkadot Bridge Hub can track and verify Kusama relay chain GRANDPA proofs. - allows to verify bridged parachain finality proofs e.g. Kusama Bridge Hub can track and verify Polkadot Bridge Hub proofs and vice versa. - allows to relay messages between them which can be verified with mentioned finality modules. Add tests for simulation: - handling `ExportMessage` on both sides - handling message dispatch and routing to target on both side - relayer can submit proofs with `submit_finality_proof` / `submit_parachain_heads` and relay messages with `receive_messages_proof` To the lane concept mentioned above, actual bridging configuration allows to send/relay/receive messages only with one hard-coded lane `[0, 0, 0, 0]`, which is dedicated lane for Kusama Asset Hub and Polkadot Asset Hub communication. Next stage will be focused on adding support to allow bridging between arbitrary parachains. More about [Bridges V2](https://github.com/paritytech/parity-bridges-common/milestone/17). Signed-off-by: Branislav Kontur <bkontur@gmail.com> Signed-off-by: Adrian Catangiu <adrian@parity.io> Signed-off-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Signed-off-by: Serban Iorga <serban@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Serban Iorga <serban@parity.io>

…upport Add congestion detection to the Bridge Hub runtimes and report congestion status to the sending chain. Bridge Hub's `ExportMessage` handling is extended with check if outbound message queue is congested, if so then `CongestedMessage` signal is sent to the sending chain's relevant `pallet-xcm-bridge-hub-router` pallet instance, where dynamic fees factor is processed. When then same Bridge Hub receives message delivery confirmation, there is a another check is outbound queue is still congested, if not then `UncongestedMessage` signal is sent to the sending chain's relevant `pallet-xcm-bridge-hub-router` pallet instance. `pallet-bridge-messages`'s `receive_messages_proof` does another check for congestion or back-preassure with checking status of underlaying XCMP queue (`cumulus_pallet_xcmp_queue::bridging::OutboundXcmpChannelCongestionStatusProvider`). If we cannot deliver a message to the target, then `receive_messages_proof` returns error and Bridge Hub does not allow to receive new bridged messages. More about congestion detection [here](paritytech/parity-bridges-common#2318). Signed-off-by: Branislav Kontur <bkontur@gmail.com> Signed-off-by: Adrian Catangiu <adrian@parity.io> Signed-off-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Signed-off-by: Serban Iorga <serban@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Serban Iorga <serban@parity.io>

Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-polkadot/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-polkadot/src/bridge_hub_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-polkadot/src/bridge_hub_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-kusama/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-kusama/src/bridge_hub_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/asset-hub-polkadot/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/asset-hub-polkadot/src/xcm_config.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Update cumulus/parachains/runtimes/assets/common/src/matching.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> Fmt + one any to all Co-authored-by: Adrian Catangiu <adrian@parity.io>

…SMs/DOTs)

Polkadot-Forum · 2023-09-13T10:01:09Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/5

…-polkadot-assets

acatangiu · 2024-01-03T12:22:42Z

closing in favor of polkadot-fellows/runtimes#108

…ubmit transactions (#1352) * CheckBridgedBlockNumber signed extension to reject duplicate header submit transactions * fix depends_on

bkontur self-assigned this Sep 1, 2023

bkontur added T6-XCM This PR/Issue is related to XCM. T9-cumulus This PR/Issue is related to cumulus. T15-bridges This PR/Issue is related to bridges. labels Sep 1, 2023

acatangiu mentioned this pull request Sep 1, 2023

asset-hubs: transfer assets via bridge using pallet-xcm #1224

Closed

bkontur force-pushed the bko-bridging-kusama-polkadot-assets branch 4 times, most recently from a8a89fc to 1da09f0 Compare September 4, 2023 11:44

svyatonik approved these changes Sep 4, 2023

View reviewed changes

acatangiu reviewed Sep 4, 2023

View reviewed changes

bkontur force-pushed the bko-bridging-kusama-polkadot-assets branch 5 times, most recently from d7f71a3 to fd705a8 Compare September 5, 2023 11:13

acatangiu approved these changes Sep 5, 2023

View reviewed changes

bkontur force-pushed the bko-bridging-kusama-polkadot-assets branch 3 times, most recently from b66e64e to bd94e75 Compare September 5, 2023 11:44

acatangiu and others added 5 commits September 5, 2023 14:39

bkontur force-pushed the bko-bridging-kusama-polkadot-assets branch from bd94e75 to 867321c Compare September 5, 2023 12:40

bkontur marked this pull request as ready for review September 5, 2023 12:40

paritytech-ci requested review from a team September 5, 2023 12:41

acatangiu mentioned this pull request Sep 6, 2023

[P-K Bridge] AssetHubs - withdraw reserve asset transfer (opposite direction) paritytech/parity-bridges-common#2405

Closed

3 tasks

Merge branch 'master' into bko-bridging-kusama-polkadot-assets

11e0931

bkontur mentioned this pull request Sep 8, 2023

Migrate asset transfer over bridge to polkadot-fellows paritytech/parity-bridges-common#2541

Closed

4 tasks

svyatonik mentioned this pull request Sep 8, 2023

Tracking issue for Polkadot Bulletin Chain <> Polkadot Bridge Hub bridge paritytech/parity-bridges-common#2547

Closed

14 tasks

Fixed local run for AssetHubKusama/AssetHubPolkadot asset transfer (K…

a3d1264

…SMs/DOTs)

bkontur added 6 commits September 19, 2023 10:54

Merge remote-tracking branch 'origin/master' into bko-bridging-kusama…

0aeb13a

…-polkadot-assets

Zombienet nits

c20f3e4

Merge remote-tracking branch 'origin/master' into bko-bridging-kusama…

80964f9

…-polkadot-assets

Merge remote-tracking branch 'origin/master' into bko-bridging-kusama…

6fe8678

…-polkadot-assets

Fix benchmarks

b2015dc

Fix benchmarks

1fd7aaa

bkontur mentioned this pull request Sep 21, 2023

cumulus: add asset-hub-rococo runtime based on asset-hub-kusama and add asset-bridging support to it #1215

Merged

8 tasks

bkontur added 9 commits September 21, 2023 15:44

Backporting nits from #1215

791d6dd

Merge remote-tracking branch 'origin/master' into bko-bridging-kusama…

2cd5e55

…-polkadot-assets

ParaIds as constants to primitives

344e0b0

Fix

d42e481

Fix

76ca00b

ensure_configuration -> prepare_configuration

03511e0

Constants nit

fc9727c

Deps

534c718

Cargo.lock

58d6319

svyatonik mentioned this pull request Oct 20, 2023

pallet-xcm: enhance reserve_transfer_assets to support remote reserves #1672

Merged

acatangiu mentioned this pull request Nov 13, 2023

[P-K Bridge][code-complete] bridge with XCM passing and AHs asset transfer support paritytech/parity-bridges-common#2689

Closed

11 tasks

dmoka mentioned this pull request Nov 29, 2023

chore: upgrade to polkadot-v1.1.0 galacticcouncil/hydration-node#691

Merged

15 tasks

acatangiu closed this Jan 3, 2024

bkchr pushed a commit that referenced this pull request Apr 10, 2024

CheckBridgedBlockNumber signed extension to reject duplicate header-s…

f64357e

…ubmit transactions (#1352) * CheckBridgedBlockNumber signed extension to reject duplicate header submit transactions * fix depends_on

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[asset-hubs/bridge-hubs] Bridging Polkadot Asset Hub <-> Kusama Asset Hub to enable asset transfer of KSMs/DOTs#1352

[asset-hubs/bridge-hubs] Bridging Polkadot Asset Hub <-> Kusama Asset Hub to enable asset transfer of KSMs/DOTs#1352
bkontur wants to merge 22 commits into
masterfrom
bko-bridging-kusama-polkadot-assets

bkontur commented Sep 1, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Polkadot-Forum commented Sep 13, 2023

Uh oh!

acatangiu commented Jan 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bkontur commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Explanation

Testing

Future Directions and Related Material

TODO

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Polkadot-Forum commented Sep 13, 2023

Uh oh!

acatangiu commented Jan 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bkontur commented Sep 1, 2023 •

edited

Loading