Fix revive-dev-node receipts issue#295
Merged
Merged
Conversation
elle-j
reviewed
Jun 1, 2026
elle-j
left a comment
elle-j
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into this!
Contributor
There was a problem hiding this comment.
@0xOmarA , was this update intentional? Seems to revert to an older rct commit
Contributor
Author
There was a problem hiding this comment.
Sorry, not intentional, will revert this today
xermicus
reviewed
Jun 1, 2026
xermicus
left a comment
xermicus
left a comment
Member
There was a problem hiding this comment.
Unfortunately we are still flaky: paritytech/revive#539
Contributor
Author
|
@xermicus Will checkout the run you linked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some of the issues we've been seeing where we sometimes fail to get the receipt for a transaction we've submitted to the chain and which we know has been included in a block. This is a client side fix and we're waiting on the upstream issues related to this to be resolved.
--pool-type single-stateas recommended by txpool: instant-seal transaction inclusion race polkadot-sdk#10104 which helped reduce these issues a lot.subxtand to watch for the transaction status after submission and resubmit any transaction which has been dropped from the mem-pool.Future Work
We could further improve this on the client side but a fix upstream is needed. A potential improvement we could do is to resubmit the transaction again after 1 minute if we don't hear any kind of status update on it so there's always selecting between two futures to see which resolves first: the
tokio::time::sleep(Duration::from_secs(60))future or the status update future. But again, we need a fix for this upstream since there isn't much more that retester can do in such cases.