Fix Retester Flakiness#540
Merged
Merged
Conversation
xermicus
approved these changes
Jun 2, 2026
| concurrency-number-of-concurrent-tasks: 50 | ||
| # Use a sane value which is fast enough to make the tests run fast but not too | ||
| # fast that it overwhelms the node. | ||
| concurrency-number-of-concurrent-tasks: 1000 |
Member
There was a problem hiding this comment.
How did you pick this number? On our hardware, is 1000 concurrent tasks actually faster than lets say 100?
Contributor
Author
There was a problem hiding this comment.
It's quite arbitrary to be honest, it's more of a trial and error and seeing what's best on the different machines.
Also, yes it does make things faster. https://github.com/paritytech/revive/actions/runs/26739486516/job/78802512016 took 37 minutes to run and this https://github.com/paritytech/revive/actions/runs/26776693394/job/78933925021 took 19 minutes to run so it's a good reduction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues with retester and some flakiness in tests. Issue is described in detail in paritytech/revive-differential-tests#296