Skip to content

Try start a Polkadot service in the background of CI #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomaka wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Try start a Polkadot service in the background of CI #1118

Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ac1f78b
Try start a Polkadot service in the background of CI
tomaka Aug 11, 2021
df41429
Not interactive
tomaka Aug 11, 2021
2ba943c
Proper image
tomaka Aug 11, 2021
94faeac
Test curl
tomaka Aug 11, 2021
35ce82a
Boop
tomaka Aug 11, 2021
1a37180
Err, need to detach the docker container
tomaka Aug 11, 2021
44b78a5
Sleep for a bit
tomaka Aug 11, 2021
fd2dac8
Ok bump the sleep time
tomaka Aug 11, 2021
09b566c
External RPC
tomaka Aug 11, 2021
424a590
--network host
tomaka Aug 11, 2021
28cd780
Needs sudo now
tomaka Aug 11, 2021
8df9cb5
Expand sudo
tomaka Aug 11, 2021
2f982db
Remove the sleep
tomaka Aug 11, 2021
d253057
Tweak check
tomaka Aug 11, 2021
4212ae6
Now the freaking yaml is invalid, it's ridiculous
tomaka Aug 11, 2021
76497eb
Add step name
tomaka Aug 11, 2021
304e035
Do a proper health request
tomaka Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,24 @@ jobs:
wasm-node-check:
name: Check javascript node
runs-on: ubuntu-latest
container:
image: rust
steps:
- name: Start Polkadot node in the background
# Note: feel free to update the Polkadot version here when one is released
run: docker run --network host -d parity/polkadot:v0.9.8 --chain polkadot-dev --unsafe-rpc-external --unsafe-ws-external
- name: Wait for node to be up
run: |
bash -c 'while true; do curl -X POST -H "Content-Type: application/json" localhost:9933; if [ $? -eq 0 ]; then break; fi; sleep 1; done'
- uses: actions/checkout@v2.3.4
- uses: actions-rs/toolchain@v1
with:
# Ideally we don't want to install any toolchain, but the GH action doesn't support this.
Copy link
Copy Markdown
Contributor

@TriplEight TriplEight Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest has rust stable built-in

Copy link
Copy Markdown
Contributor

@TriplEight TriplEight Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this job

Copy link
Copy Markdown
Contributor Author

@tomaka tomaka Aug 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need rustup though, not just rust, because the tests make use of rustup.

Copy link
Copy Markdown
Contributor

@TriplEight TriplEight Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have it there

Copy link
Copy Markdown
Contributor

@TriplEight TriplEight Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e.

toolchain: stable
profile: minimal
- uses: Swatinem/rust-cache@v1
- uses: actions/setup-node@v2.4.0
with:
node-version: '12'
- run: apt-get update && apt install -y binaryen # For `wasm-opt`
- run: sudo apt-get update && sudo apt install -y binaryen # For `wasm-opt`
- run: cd bin/wasm-node/javascript && npm install-ci-test

check-features:
Expand Down