bitswap_unstable_stream added#3264
Open
michalkucharczyk wants to merge 18 commits into
Open
Conversation
lrubasze
reviewed
May 27, 2026
| format!("Bitswap stream subscription: {} cids", cids.len()) | ||
| ); | ||
|
|
||
| match me.bitswap_service.bitswap_stream(cids).await { |
Contributor
There was a problem hiding this comment.
Not sure if I'm right but is client connection blocked while awaiting here?
Contributor
Author
There was a problem hiding this comment.
The await covers only the synchronous handoff (parse_and_dedup + a channel send + a oneshot for the BatchId), not the actual Have broadcast or per-CID events - those flow later via the events-pump task pushed to background_tasks at line 1220 (light-base/src/json_rpc_service/background.rs).
The only backpressure could be the bitswap service's bounded inbound channel being saturated - I think this shall not happen.
Any ideas how to solve it in different way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
bitswap_unstable_streammethod defined in paritytech/json-rpc-interface-spec#186It also improves the e2e test for
bitswap_unstable_getwhich was added in #3240