respect millimetre notation in 3d labels#540
Open
tylergibbs1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what does this pr do?
fixes #509 by completing the label only millimetre preference across 3d measurement surfaces that still defaulted to metres.
how to test
local validation completed with a 1,329 file biome check and 25 passing measurement tests. i could not run bun dev or package type checks because the filtered dependency install exceeded the available disk space on the five remaining runtime packages.
screenshots / screen recording
not included. this change only wires the existing display preference into the remaining label paths.
checklist
Note
Low Risk
Display-only wiring of an existing viewer preference through label formatters; no persistence, auth, or geometry logic changes.
Overview
3D linear readouts now follow the viewer’s metric notation (metres vs millimetres) instead of defaulting to metres when millimetres are selected.
The change threads
metricNotationfromuseViewerinto alignment guides, opening/dormer placement pills, floating action menu height and HVAC run-length summaries, dimension pills, saved measurement labels, and in-progress measurement draft previews.formatMeasurementin the editor now delegates toformatLinearMeasurement, so formatting stays aligned with the shared rules (including signs and sub‑millimetre rounding). Area and volume labels are unchanged.Tests add millimetre formatting cases for values like
0.2m→200mmand half‑millimetre rounding to1mm.Reviewed by Cursor Bugbot for commit 5887d3a. Bugbot is set up for automated code reviews on this repo. Configure here.