Conversation
If we use --override-input the shortRev and dirtyShortRev attribute on the flake both seem to be unset. We use a simple default string in that case to compute the version string for the alot package.
|
let's wait for a copilot review, then amend/ignore it, and you can merge? |
There was a problem hiding this comment.
Pull request overview
This PR updates the Nix flake to make version computation resilient when the flake is built with overridden inputs (e.g., different nixpkgs), and refreshes the CI Nix installer action.
Changes:
- Compute a
versiononce at the flake output level with a fallback whenshortRev/dirtyShortRevare unavailable. - Refactor the Nix packaging to build a Python package (
buildPythonPackage) and then produce an application viatoPythonApplication, plus add atheme-testpackage. - Bump
cachix/install-nix-actionused in CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
flake.nix |
Adjusts version derivation logic and refactors Python/Nix packaging; adds a theme-test derivation. |
.github/workflows/check.yml |
Updates the GitHub Action used to install Nix during CI jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@pazz yes I can merge in theory but only if the PR has one approving review (not from me if I am the author). That is the branch protection rule for master. And that was the reason for calling out to you here in the first place. I think I need the approval from you (as we are the only people with commit rights, no?) |
|
here we go :) thanks |
I had the case in #1715 that I wanted to build alot with an update version of nixpkgs. But our code to compute the version did not evaluate for that.