Set ui global body color on update.#1720
Open
dylanfprice wants to merge 1 commit into
Open
Conversation
Owner
|
does the above commit fix the issue for you? |
Contributor
Author
Owner
|
Thanks for the quick fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug with my recently merged PR #1711. When switching the theme using the
themecommand, the global body color is not updated.I didn't notice this until I switched to a dark theme and also changed my terminal background color to match. The background color of alot remained what it was in the light theme.
The issue is that the global body attribute is only set in the
UI.__init__constructor. I fixed it by setting the global body attribute again in theUI.updatemethod.Testing:
I did basic manual testing that the
themecommand now changes the background color. Doesn't look like there are any unit tests for theUIclass so I didn't attempt to add any.