Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Formula/rute-bayar.rb
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
class RuteBayar < Formula
desc "Payment router CLI and webhook daemon for Indonesian payment gateways"
homepage "https://github.com/pendig/rute-bayar"
version "0.1.8"
version "0.1.9"
license "MIT"

on_macos do
if Hardware::CPU.arm?
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-arm64"
sha256 "f01ede6cab4b3f432295fd5bd7368701a279bab552094ee1525ca54d5e6dca6e"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-darwin-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby, which means the URL will literally contain #{version} instead of evaluating to 0.1.9. This will cause the download to fail. Please remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore version interpolation in download URLs

Because the # is escaped inside these double-quoted strings, Ruby leaves the URL path as the literal v#{version} instead of expanding it to v0.1.9 (confirmed with ruby -e 'version="0.1.9"; puts "v\\#{version}"'). That makes every platform URL in this formula point at a non-existent GitHub release path, so brew install rute-bayar will fail before checksum verification.

Useful? React with 👍 / 👎.

sha256 "77c01a4bf43b034acb49d6d5837a6bc3c6f7b1c4538fde7847ca580d94c33104"
else
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-amd64"
sha256 "a04c56c75bdd92775cdad5aaaa7aa06b521f663523b96bd45a5190478bffa175"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-darwin-amd64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby, which means the URL will literally contain #{version} instead of evaluating to 0.1.9. This will cause the download to fail. Please remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-amd64"

sha256 "c50d84a732ed9edc3c5ef8cc0c5816a4b77e9daa583f62d3a969894c0c3dece6"
end
end

on_linux do
if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-arm64"
sha256 "aa6aa2a8454192e879da7d2ff4ee97e1b51f5669b11c9f0cfd508a0cffb3896a"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-linux-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby, which means the URL will literally contain #{version} instead of evaluating to 0.1.9. This will cause the download to fail. Please remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-arm64"

sha256 "2b3726e0d46c114e41c97f868801840277a067aaabed8ff4a3dd62124f6817c9"
else
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-amd64"
sha256 "a0c7c48fe0467fff629689b5c4df6ad15ebe03a6bd174bdab2110022cc5bdf70"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-linux-amd64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby, which means the URL will literally contain #{version} instead of evaluating to 0.1.9. This will cause the download to fail. Please remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-amd64"

sha256 "628a4f22e55f78cd351a144f7aece2ba156fe6b5d6d80f8f1a4a4b21762a8d3e"
end
end

Expand Down