PMM-15138 Fix alerting permissions#5493
Open
ademidoff wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #5493 +/- ##
==========================================
+ Coverage 43.46% 43.49% +0.03%
==========================================
Files 413 413
Lines 42928 42935 +7
==========================================
+ Hits 18659 18675 +16
+ Misses 22393 22385 -8
+ Partials 1876 1875 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ademidoff
requested review from
4nte and
maxkondr
and removed request for
a team
4nte
approved these changes
Jun 12, 2026
JiriCtvrtka
approved these changes
Jun 12, 2026
maxkondr
reviewed
Jun 12, 2026
Co-authored-by: Maxim Kondratenko <maxim.kondratenko@percona.com>
The nginx auth layer returned 401 for permission denials, which triggers the error_page 401 re-run against /auth_request as a GET. For method-specific rules (e.g. POST /v1/alerting/templates) the GET re-run is allowed, so the client received a misleading 200 even though the write was blocked. Map PermissionDenied to 403 so nginx denies outright via error_page 403, which serves a static body without re-running. Unauthenticated stays 401.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15138
Feature build: SUBMODULES-4403
Ref: percona/pmm-qa#1014