Skip to content

Backport #1141's flaky-test fixes to the stable branches #1179

Description

@petergoldstein

#1141 (115ded5) fixed three flaky tests on main:

  1. KeyManager: in "when the key with namespace is shorter than 250 characters", the generated key length didn't account for the : separator, so about 1 run in 250 produced a 251-character key, which gets hashed and fails the assertion.
  2. The Rack session freshness test raced its 1-second TTL.
  3. MemcachedManager: failed_start could leave a process holding a port, and stop didn't confirm the port was released.

5-1-stable has the fix. 3-2-stable, 4-3-stable and 5-0-stable don't, and the KeyManager flake failed release PRs this week:

Backporting 115ded5 to those three branches should remove all three flakes there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions