Prepare 5.1.2 release - #1173
Merged
Merged
Conversation
getk_response_from_buffer returned the no-body result for any header with a zero size, which the pipelined getter reads as the terminating MN. A VA 0 hit therefore ended the server's pipeline early, dropping its remaining keys and leaving the rest of its replies unread on the connection. Parse a VA 0 as an empty value instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6d17ef9)
Every job that builds memcached (Tests, Benchmarks, Profiles) started failing with 404s fetching libevent-2.1-7t64 2.1.12-stable-9ubuntu2.1: the runner image's package index still lists a version Ubuntu's mirrors have replaced. Run apt-get update before installing, and pass -y so the install can't wait on a prompt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 1bc2226)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases 5.1.2, a backport of #1170 to the 5.1.x line.
get_multistopped reading a server's replies at a hit on an empty value (VA 0). The rest of that server's keys were silently missing, and the unread replies were taken as the replies to later commands on the connection. A single-keygetcould then return another key's value. An empty value is now parsed as''.apt-get updatebefore installing libevent), without which every memcached-building job fails on current runner images.Testing
VA 0, and a 2-server integration test with 100 keys of 20KB and one empty value, checking the hash and block forms ofget_multiand agetof every key afterwards. All of them fail without the fix and pass with it.🤖 Generated with Claude Code