Repository navigation
feat(release): let one run stage more than one build (ENG-3550) - #110
Merged
Merged
Conversation
Two calls to package-stage in the same workflow run both uploaded an artifact named package-release, and the second failed. The name is now an input, so a repository can release its packages on separate lines from one run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Frudrax Cheng (auroursa)
requested a review
from Tom Tang (qwerzl)
as a code owner
October 10, 2026 08:28
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ENG-3550.
Problem
A repository with two packages that have to be released separately cannot stage them from one workflow run. Each call to
package-stageuploads its build as an artifact namedpackage-release, and artifact names are unique within a run, so the second call fails at the upload.Staging them in one run matters: the calls share the run's staging suffix, so the second package can depend on the exact staging version of the first.
Change
package-stagetakes anartifact-nameinput, defaultpackage-release. The build job uploads under it and the publish job downloads it. Existing callers are unaffected.The README describes this under the multi-package notes.
Validation
python3 -m unittest discover -s test: 25 tests pass, including a new one asserting the default and that the upload and the download are the only steps that use the name. The release tool is untouched.CI on this pull request is pending. Two calls in one run are exercised by the first caller that adopts this.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
Documentation