add optional dnsmasq features to cmake#2874
Open
darkexplosiveqwx wants to merge 1 commit into
Open
Conversation
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Contributor
Author
|
Some questions: And should I call it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Allow to enable build-time dnsmasq features if the development headers / libraries are present.
I am using Fedora 42 and the cmake RPM macro presets from %cmake and %cmake_build
Compilation works:
Absence is correctly detected:
How does this PR accomplish the above?:
The change in
FindDBus.cmakeis necessary, otherwise CMake will complain with:I have also removed the reference to
DNSMASQ_ALL_OPTS, a quickrgyielded no other matches.It was originally added in #1472, but the associcated CMake part was removed in #1962 (github blame only a bit helpful when searching for removed lines).
With now being able to enable the features one-by-one this is no longer needed.
By submitting this pull request, I confirm the following:
git rebase)