Skip to content

Renaming of ERW-related variables - #817

Open
tabeado wants to merge 5 commits into
pik-piam:masterfrom
tabeado:master
Open

Renaming of ERW-related variables#817
tabeado wants to merge 5 commits into
pik-piam:masterfrom
tabeado:master

Conversation

@tabeado

@tabeado tabeado commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Purpose of this PR

Adjustments in connection to REMIND-PR 2411

  • Renaming of s33_co2_rem_pot to s33_rockRemPot
  • Deletion of s33_costs_fix and renaming of vm_omcosts_cdr to vm_EW_transport_costs

Checklist:

I checked the tests when running buildLibrary and made sure that my changes

  • do not create new complaints about summation checks.
  • do not create new complaints about missing variables that are expected in the piamInterfaces package. (If needed, adjust piamInterfaces mappings based on the README.md. In case of complaints unrelated to your changes that you are unable to fix, please open an issue in piamInterfaces.)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Enhanced Weathering (EW) LCOE reporting to reflect the variable rename from s33_co2_rem_pot to s33_rockRemPot, while keeping backward compatibility by falling back to the old name when needed.

Changes:

  • Replaced the EW removal-potential input read from GDX to prefer s33_rockRemPot and fall back to s33_co2_rem_pot.
  • Updated the downstream EW-induced removal calculation to use the renamed variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tabeado tabeado changed the title Renaming s33_co2_rem_pot to s33_rockRemPot Renaming of ERW-related variables Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants