Add new checker MicSecondaryRoot#1100
Conversation
|
Hi antoinre this is an excellent start. We should check that the filename is well stored in the secondaryRoot. Probably in practice we will need something like We will see. |
| ] | ||
|
|
||
| { #category : 'testing' } | ||
| MicChecker >> visitSecondaryRootBlock: aSecondaryRootBlock [ |
There was a problem hiding this comment.
We should add a visitSecondaryRootBlock: in the default MicrodownVisitor it can just call the logic of rootblock eg. visitRootBlock:
| ] | ||
|
|
||
| { #category : 'debugging' } | ||
| MicRootBlock >> isSecondaryRoot [ |
There was a problem hiding this comment.
It could be smarter. I wonder. Because a main root block parent is nil while by construction a secondaryRootBlock should be nested into something.
| #name : 'MicSecondaryRootBlock', | ||
| #superclass : 'MicRootBlock', | ||
| #instVars : [ | ||
| 'file' |
There was a problem hiding this comment.
If you look in the superclass fromFile is already defined so
either we use fromFile implementation (I do not remember but may be it was with managed with a property and we could move it using an instance variable (and remove the implementation in secondaryRootBlock
|
Can you have a look at the test of fileIncluder and see how we extend them to take into account the use of MicSecondaryRootBlock? |
|
|
|
||
| { #category : 'testing' } | ||
| MicSecondaryRootBlock >> fromFile: aFileOrResource [ | ||
| self propertyAt: #file put: aFileOrResource |
There was a problem hiding this comment.
Je pense que nous avons la meme methode dans la superclasse
2 participants
Fix #1099