Repository navigation
🤖 [claude] Review follow-ups for v0.1.1-fh3.1-1: changelog accuracy, stale comment - #4
Merged
Conversation
…comment The v0.1.1-fh3.1-1 changelog entry claimed identical sources to StreamingFast's tag while this branch also rewrites read_all_system_contracts for clippy; list that under Fixed and limit the identity claim to Cargo.toml/Cargo.lock. The sf-release.yml secrets comment described a private reth fork nothing pins. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YHvxpuVpZfzefJgwgqjAzn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only follow-ups from the review of #2, which merged a few minutes before this commit was pushed to the branch:
CHANGELOG.md: thev0.1.1-fh3.1-1entry claimed identical sources to StreamingFast'sv0.1.1-fh3.1while 🤖 [claude] Seed the Pinax Firehose release pipeline from streamingfast v0.1.1-fh3.1 #2 also rewroteread_all_system_contractsfor clippy 1.98. The identity claim is now limited toCargo.toml/Cargo.lockand the clippy change is listed under Fixed. The GitHub release body is extracted from this file at the tag, so this should land beforev0.1.1-fh3.1-1is cut.sf-release.yml: thesecrets:comment described a private reth fork that nothing on this branch pins; aligned with the header.No code or dependency changes (
git diff acc20c37c..bbd8e02 -- src Cargo.toml Cargo.lockis empty).Test plan
ci.ymlgreen onbbd8e02(push run)🤖 Created by Claude Code Fable 5.1 (effort: low)
🤖 Generated with Claude Code
https://claude.ai/code/session_01YHvxpuVpZfzefJgwgqjAzn