Skip to content

parser: modify parser to support partial index#63448

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
YangKeao:partial-index-0
Sep 12, 2025
Merged

parser: modify parser to support partial index#63448
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
YangKeao:partial-index-0

Conversation

@YangKeao
Copy link
Copy Markdown
Member

@YangKeao YangKeao commented Sep 10, 2025

What problem does this PR solve?

Issue Number: close #63447

-> #63448
#62759
#62762

Problem Summary:

What changed and how does it work?

Modify the parser to support partial index grammar

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.6173%. Comparing base (bd7b6f8) to head (66ba465).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63448        +/-   ##
================================================
+ Coverage   72.7843%   73.6173%   +0.8330%     
================================================
  Files          1835       1839         +4     
  Lines        496868     503252      +6384     
================================================
+ Hits         361642     370481      +8839     
+ Misses       113275     110899      -2376     
+ Partials      21951      21872        -79     
Flag Coverage Δ
integration 42.8936% <ø> (?)
unit 72.7407% <40.0000%> (+0.4265%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (+0.1132%) ⬆️
parser ∅ <ø> (∅)
br 46.5193% <ø> (+0.0203%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread pkg/parser/ast/ddl.go Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2025
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Copy Markdown
Member Author

/retest

Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-10 11:18:20.788369206 +0000 UTC m=+446567.348250703: ☑️ agreed by wjhuang2016.
  • 2025-09-12 00:54:50.7243239 +0000 UTC m=+581957.284205397: ☑️ agreed by bb7133.

@YangKeao
Copy link
Copy Markdown
Member Author

YangKeao commented Sep 12, 2025

I just realized that it needs sig-critical-approvers-parser to approve.

/cc @yudongusa

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, wjhuang2016, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 12, 2025
@hawkingrei
Copy link
Copy Markdown
Member

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 7b93bcb into pingcap:master Sep 12, 2025
28 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jun 1, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #68830.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the parser of partial index

6 participants