Skip to content

parser: modify parser to support partial index (#63448) #65698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YangKeao wants to merge 1 commit into from
Closed

parser: modify parser to support partial index (#63448) #65698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pkg/parser/ast/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,7 @@ type IndexOption struct {
Visibility IndexVisibility
PrimaryKeyTp model.PrimaryKeyType
Global bool
Condition ExprNode `json:"-"` // Condition contains expr nodes, which cannot marshal for DDL job arguments. It's used for partial index.
}

// IsEmpty is true if only default options are given
Expand All @@ -746,7 +747,8 @@ func (n *IndexOption) IsEmpty() bool {
len(n.ParserName.O) > 0 ||
n.Comment != "" ||
n.Global ||
n.Visibility != IndexVisibilityDefault {
n.Visibility != IndexVisibilityDefault ||
n.Condition != nil {
return false
}
return true
Expand Down Expand Up @@ -820,6 +822,17 @@ func (n *IndexOption) Restore(ctx *format.RestoreCtx) error {
ctx.WriteKeyWord("INVISIBLE")
}
}

if n.Condition != nil {
if hasPrevOption {
ctx.WritePlain(" ")
}
ctx.WriteKeyWord("WHERE ")
if err := n.Condition.Restore(ctx); err != nil {
return errors.Annotate(err, "An error occurred while splicing IndexOption Condition")
}
}

return nil
}

Expand Down
Loading