Skip to content

pkg/util/workloadrepo: stabilize flaky TestCreatePartition #67793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 3 commits into from
May 17, 2026
+3 −1
Merged

pkg/util/workloadrepo: stabilize flaky TestCreatePartition #67793

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4b5ca
fix: stabilize flaky issue #67461
flaky-claw Apr 15, 2026
4310e3e
pkg/util/workloadrepo: address review comments
yinsustart May 9, 2026
581fa1e
pkg/util/workloadrepo: minimize partition test fix
flaky-claw May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/util/workloadrepo/worker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,9 @@ func TestCreatePartition(t *testing.T) {
wrk.fillInTableNames()

now := time.Now()
// The test builds date-based partitions with AddDate and TO_DAYS, so anchor at noon to avoid
// instability around wall-clock day boundaries.
now = time.Date(now.Year(), now.Month(), now.Day(), 12, 0, 0, 0, now.Location())

/* Tables without partitions are not currently supported. */

Expand Down Expand Up @@ -711,7 +714,6 @@ func TestCreatePartition(t *testing.T) {
createTableWithParts(ctx, t, tk, getTable(t, "TIDB_STATEMENTS_STATS", wrk), sess, partitions)

// turn on the repository and see if it creates the remaining tables
now = time.Now()
wrk.setRepositoryDest(ctx, "table")
waitForTables(ctx, t, wrk, now)
}
Expand Down
Loading