-
Notifications
You must be signed in to change notification settings - Fork 6.2k
ddl,tables: only write the index when it meets partial index condition (#62762) #68833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ti-chi-bot
wants to merge
1
commit into
pingcap:release-8.5
Choose a base branch
from
ti-chi-bot:cherry-pick-62762-to-release-8.5
base: release-8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,749
−165
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| #!/bin/sh | ||
| # | ||
| # Copyright 2025 PingCAP, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -eu | ||
| DB="$TEST_NAME" | ||
|
|
||
| run_sql "CREATE DATABASE $DB;" | ||
|
|
||
| run_sql " | ||
| USE $DB; | ||
|
|
||
| CREATE TABLE t0 ( | ||
| id int primary key, | ||
| col1 int, | ||
| col2 int, | ||
| key idx_col1 (col1) where col2 > 10 | ||
| ); | ||
| INSERT INTO t0 VALUES (1, 1, 1); | ||
| INSERT INTO t0 VALUES (2, 2, 15); | ||
| INSERT INTO t0 VALUES (3, 3, 1); | ||
| INSERT INTO t0 VALUES (4, 4, 20); | ||
| INSERT INTO t0 VALUES (5, 5, 1); | ||
| " | ||
|
|
||
| # backup table | ||
| echo "backup start..." | ||
| run_br --pd $PD_ADDR backup db -s "local://$TEST_DIR/$DB" --db $DB | ||
|
|
||
| run_sql "DROP DATABASE $DB;" | ||
| run_sql "CREATE DATABASE $DB;" | ||
|
|
||
| # restore table | ||
| echo "restore start..." | ||
| run_br restore db --db $DB -s "local://$TEST_DIR/$DB" --pd $PD_ADDR | ||
|
|
||
| if run_sql "admin check table ${DB}.t0;" | grep -q 'inconsistency'; then | ||
| echo "TEST: [$TEST_NAME] failed after restoring $DB.t0" | ||
| exit 1 | ||
| fi | ||
|
|
||
| run_sql "show create table $DB.t0;" | ||
| check_contains "WHERE \`col2\` > 10" | ||
|
|
||
| run_sql "DROP DATABASE $DB;" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unresolved merge conflict markers must be removed.
The merge conflict markers (
<<<<<<< HEAD,=======,>>>>>>>) are still present in the shell script. This will cause syntax errors when the script is executed.🔧 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.11.0)
[error] 30-30: Fix any mentioned problems and try again.
(SC1072)
🤖 Prompt for AI Agents