*: add keyspace observability labels#68836
Conversation
|
@zeminzhou I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details. ⏳ This process typically takes 10-30 minutes depending on the complexity of the changes. ℹ️ Learn more details on Pantheon AI. |
|
Hi @zeminzhou. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughAdds keyspace-observability config, resolves activation metadata into metric labels and log fields at Starter startup (TiKV only), refactors metrics initialization to include those labels, and injects observability fields into slow logs and statement-summary JSON with accompanying tests and BUILD updates. ChangesKeyspace Observability Configuration and Integration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #68836 +/- ##
================================================
- Coverage 76.3085% 75.2834% -1.0252%
================================================
Files 2041 2026 -15
Lines 563262 568400 +5138
================================================
- Hits 429817 427911 -1906
- Misses 132529 140420 +7891
+ Partials 916 69 -847
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ChangRui-Ryan: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@ChangRui-Ryan: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…yspace-observability-master # Conflicts: # cmd/tidb-server/main.go # pkg/config/BUILD.bazel # pkg/config/config.go # pkg/standby/BUILD.bazel # pkg/standby/standby_test.go
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChangRui-Ryan, D3Hunter, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #67765
more detials: #68405
Problem Summary:
Cherry-pick keyspace observability changes from release-nextgen to master:
What changed and how does it work?
Keyspace_meta_prefix for slow log field names.Check List
Tests
go test ./pkg/config -run '^(TestKeyspaceObservability|TestKeyspaceObservabilityInvalid|TestDeployModeConfig)$' -count=1go test ./pkg/util/metricsutil -run '^TestRegisterMetricsWithKeyspaceObservabilityValues$' -count=1go test ./pkg/standby -run '^(TestActivateRequestMetadata|TestActivateRequiresKeyspaceName)$' -count=1go test ./pkg/util/stmtsummary/v2 -run '^TestStmtRecord$' -count=1./tools/check/failpoint-go-test.sh cmd/tidb-server -tags=intest,deadlock,nextgen -run '^TestSetupKeyspaceObservabilityForStarter' -count=1./tools/check/failpoint-go-test.sh pkg/store/driver -run '^TestSetDefaultAndOptions$' -count=1go test -tags=intest,deadlock ./pkg/sessionctx/variable/tests -run '^TestSlowLogFormat$' -count=1Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
New Features
Tests