*: Update kvproto, pd client, client-go to follow GC API changes#68843
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBump kvproto/client-go/pd deps and adapt mock GC client signatures and tests so GCStatesClient methods accept variadic pdgc.GCStatesAPIOption; mock implementations apply options to include/exclude GC barriers and tests use GetGCBarriers()/require checks. ChangesGC API Options Adaptation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @MyonKeminta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
@MyonKeminta I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details. ⏳ This process typically takes 10-30 minutes depending on the complexity of the changes. ℹ️ Learn more details on Pantheon AI. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/store/mockstore/unistore/tikv/mock_pd_test.go`:
- Around line 93-96: Add an assertion that checks the error returned by
s.GetGCBarriers() before using gcBarriers: after calling s.GetGCBarriers() in
the test block where gcBarriers and err are assigned, call re.NoError(err) so
any error is caught immediately and the assignment isn't silently unused; target
the GetGCBarriers() call and the gcBarriers/err variables in mock_pd_test.go
(the same pattern used at the other GetGCBarriers() sites).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 64d06462-b4a5-407a-88cf-b41e0fd83440
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
DEPS.bzldumpling/export/util_for_test.gogo.modpkg/store/mockstore/unistore/tikv/mock_pd_test.gopkg/store/mockstore/unistore/tikv/mock_region.go
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #68843 +/- ##
================================================
- Coverage 76.3104% 76.2588% -0.0517%
================================================
Files 2041 2044 +3
Lines 563452 572193 +8741
================================================
+ Hits 429973 436348 +6375
- Misses 132563 134528 +1965
- Partials 916 1317 +401
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, cfzjywxk, D3Hunter, ekexium, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
0fabd47 to
f502701
Compare
|
/retest |
|
@MyonKeminta: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
What problem does this PR solve?
Issue Number: close #68844, ref tikv/pd#10659
Problem Summary:
What changed and how does it work?
This PR updates dependencies (kvproto, PD client, client-go) and adapt to the latest incompatible changes to GC states API.
Requires:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
Chores
Tests