fix(vendor): forward testID from VirtualList to its outer container - #120
Merged
Conversation
DouweBos
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes a framework change developed against the client's
vendor/react-lightningembed.What changed
VirtualListforwardstestIDto its outer container.VirtualListPropswas a closed interface with notestID, and the compiled output had no rest-spread either, so the prop was silently dropped and never reached an element. Any screen whose root is aVirtualListwas therefore invisible to test tooling matching on it.testIDis now declared onLightningViewElementProps. The react-native compat layer already passed it through untyped andLightningViewElementalready treats it as an inert prop, so this documents what was happening at runtime rather than changing behavior.Why
A Maestro E2E flow asserting a screen id (
screen-account-history) failed on Lightning while the screen rendered correctly, because that screen's root is aFlashListand the id died at theVirtualListboundary. This affects every FlashList-rooted screen, not just the one flow.Validation
Verified in
plexinc/react-native-clientagainst the embedded copy: the flow that asserted the dropped id now passes, taking that suite from 7/10 to 8/10.check:typesis clean on both touched packages and the vendored unit suite passes (72 files / 804 tests).No render harness exists in these packages, so there's no unit test for the passthrough. The E2E assertion is the coverage.
Client-side integration stays in the client repo until a release is cut. A changeset is included so both packages get a patch bump.