Skip to content

Remove RTD PR preview build workflow#2091

Merged
stevepiercy merged 1 commit into
6.0from
remove-rtd-pr-preview-workflow
Jun 23, 2026
Merged

Remove RTD PR preview build workflow#2091
stevepiercy merged 1 commit into
6.0from
remove-rtd-pr-preview-workflow

Conversation

@stevepiercy

@stevepiercy stevepiercy commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

We now use the [RTD GitHub app](https://docs.readthedocs.com/platform/stable/reference/git-integration.html#github-app), making the removed file redundant to pull request preview builds. Additionally, the call to the old GitHub Action was deprecated on 2025-07-01, per https://github.com/readthedocs/actions/blob/main/README.md.

@davisagli davisagli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm taking your word that this is no longer needed, since I'm not familiar with the new RTD github app.

@stevepiercy stevepiercy merged commit 56f497d into 6.0 Jun 23, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from New to Approved in Plone Documentation Jun 23, 2026
@stevepiercy stevepiercy deleted the remove-rtd-pr-preview-workflow branch June 23, 2026 21:24
@github-project-automation github-project-automation Bot moved this from Approved to Done in Plone Documentation Jun 23, 2026
@stevepiercy

Copy link
Copy Markdown
Contributor Author

@davisagli yup, this workflow isn't needed. I tested first in icalendar to verify. Its removal saves a CI check and energy usage. 🌎

I also posted to the community forum a more detailed report with an additional warning about the workflow calls pull_request_target and workflow_run. It was a shallow rabbit hole day yesterday for me.

https://community.plone.org/t/remove-rtd-pr-preview-build-workflow-file-and-a-warning-about-github-actions-v7/23083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants