Skip to content

refactor(arkworks): return SEC1 bytes directly - #155

Open
wj00243-lgtm wants to merge 1 commit into
plume-sig:mainfrom
wj00243-lgtm:codex/arkworks-sec1-array
Open

wj00243-lgtm wants to merge 1 commit into
plume-sig:mainfrom
wj00243-lgtm:codex/arkworks-sec1-array

Conversation

@wj00243-lgtm

Copy link
Copy Markdown

Summary

  • change rust-arkworks sec1_affine to return the 33-byte SEC1 compressed encoding directly
  • remove the deprecated helper wrapper while preserving identity encoding internally for challenge preimages
  • update SEC1 encoding tests to use the direct byte-array API

Why

Issue #88 notes that rust-arkworks is over-generalized, including the concrete follow-up that affine-to-bytes should return [u8; 33]. This PR keeps the scope narrow and only addresses that API simplification.

Tests

  • added sec1_affine_returns_compressed_bytes_directly
  • updated test_point_sec1_encoding
  • git diff --check passed
  • cargo test was not run locally because cargo/rustc is not available in this environment

Closes #88

@wj00243-lgtm
wj00243-lgtm marked this pull request as ready for review May 21, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<./rust-arkworks> is over generalized

2 participants